Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev extensions #1415

Closed
Closed

Conversation

research11111
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@welcome
Copy link

welcome bot commented Oct 27, 2023

Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests.

# compilers that support that notion.
include_directories(SYSTEM ${EIGEN3_INCLUDE_DIR})

cmake_minimum_required(VERSION 3.5)
Copy link
Member

@cryos cryos Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense and is not the direction we want to move the CMake code in this project. We use components, target level properties.

Copy link
Contributor Author

@research11111 research11111 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistake i remove

@research11111
Copy link
Contributor Author

This pull request addresses Issue #1391 and includes the following enhancements:

  • Sets the Python path similarly to how the quantumInput extension does.
  • Partial support for virtualenv; manual path input is required from the user.
  • Enables the addition of custom plugin URLs (GitHub-hosted only).
  • Allows local download of the plugins.json file and the ability to add entries to it.
  • Supports installations both with and without Conda.
  • Features auto-detection of existing installations.
  • Automates the installation of dependencies, either from requirements.txt or pyproject.toml (https://github.com/research11111/avogadro-rdkit/ may be used to validate).

@research11111
Copy link
Contributor Author

add CMakeFile

@research11111 research11111 deleted the dev-extensions branch October 27, 2023 18:52
@research11111 research11111 restored the dev-extensions branch October 27, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants