Test RA authentication unhappy flow #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/ra-authn-error
branch
2 times, most recently
from
3bfc4c1 to
8b3ea28
Compare
It refered to a non existing key. Causing issues when consuming the assertion from the gssp in the Gateway. The dreaded signature validation failure would occur
MKodde
force-pushed
the
feature/ra-authn-error
branch
from
8b3ea28 to
3ed0140
Compare
MKodde
commented
Sep 19, 2024
Comment on lines
+720
to
+723
| public function andIDie() | ||
| { | ||
| $this->diePrintingContent(); | ||
| } |
There was a problem hiding this comment.
Usefull when writing the test, to view what's happening in the browser
Comment on lines
+24
to
+25
| Scenario: User "joe-a3" tries to login while no acceptable 2FA token is available | ||
| Given a user "joe-a3" identified by "urn:collab:person:institution-a.example.com:joe-a3" from institution "institution-a.example.com" |
There was a problem hiding this comment.
Arguably, this scenario looks a lot like the previous one.. But it is somewhat different as this time the idenitty does have a token (but it is not suitable)
johanib
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging in to the RA is not possible, we need to be sure the right error page is displayed. That is tested here.
See: https://www.pivotaltracker.com/n/projects/1163646/stories/188230772
See: OpenConext/Stepup-RA#332