Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stepup config after install #18

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

pablothedude
Copy link
Contributor

Make some changes in the Setpup config after first install

  • Update documentation
  • Add MariaDB healthcheck to prevent running commands when not healthy
  • Cleanup duplicate Behat docker compose config

@pablothedude pablothedude force-pushed the feature/update-stepup-config-after-install branch 3 times, most recently from e6bb28d to 4660121 Compare November 4, 2024 12:28
@pablothedude pablothedude force-pushed the feature/update-stepup-config-after-install branch from 8ea9e94 to 4660121 Compare November 4, 2024 12:41
Copy link
Contributor

@quartje quartje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
The extra behat composer file was there so that container would only be started when running tests and not in other circumstances. But I guess we can better solve that using docker compose profiles

stepup/README.md Outdated
@@ -117,16 +117,17 @@ STEPUP_VERSION=test
3. Choose if you want to run the containers in the back- or foreground.

3: Once the containers are up and running, you can run the behat tests
1. Open a shell in the `behat` container `$ docker exec -it stepup-behat-1 bash`
2. Run the tests:
1. Install the required dependencies in the container `$ docker compose exec composer install`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker compose exec behat composer install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed the command

@pablothedude
Copy link
Contributor Author

Nice work! The extra behat composer file was there so that container would only be started when running tests and not in other circumstances. But I guess we can better solve that using docker compose profiles

I saw that the config was already present in the docker compose file and the separate file was a duplicate because the contents were the same.

Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections your honor

@pablothedude pablothedude force-pushed the feature/update-stepup-config-after-install branch from 99458ff to 72a49a0 Compare November 7, 2024 09:17
@pablothedude pablothedude merged commit 3dc9620 into main Nov 7, 2024
2 checks passed
@pablothedude pablothedude deleted the feature/update-stepup-config-after-install branch November 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants