-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stepup config after install #18
Conversation
e6bb28d
to
4660121
Compare
8ea9e94
to
4660121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The extra behat composer file was there so that container would only be started when running tests and not in other circumstances. But I guess we can better solve that using docker compose profiles
stepup/README.md
Outdated
@@ -117,16 +117,17 @@ STEPUP_VERSION=test | |||
3. Choose if you want to run the containers in the back- or foreground. | |||
|
|||
3: Once the containers are up and running, you can run the behat tests | |||
1. Open a shell in the `behat` container `$ docker exec -it stepup-behat-1 bash` | |||
2. Run the tests: | |||
1. Install the required dependencies in the container `$ docker compose exec composer install` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker compose exec behat composer install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changed the command
I saw that the config was already present in the docker compose file and the separate file was a duplicate because the contents were the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections your honor
99458ff
to
72a49a0
Compare
Make some changes in the Setpup config after first install