Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pre-commit-ci #35

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Adding pre-commit-ci #35

merged 7 commits into from
Mar 11, 2024

Conversation

ijpulidos
Copy link
Contributor

@ijpulidos ijpulidos commented Mar 8, 2024

Adding pre-commit-ci support to be able to have a standard and centralized way to deal with basic code formatting.

Solves #34

@IAlibay
Copy link
Member

IAlibay commented Mar 8, 2024

openfe 0.1

👀 DId something change upstream?

@ijpulidos
Copy link
Contributor Author

ijpulidos commented Mar 8, 2024

@IAlibay For some reason the solver resolves to openfe=0.1, that's why I had to pin >=0.15 in 7d59d63

It shouldn't be a problem once #24 is merged

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 87.69231% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 86.18%. Comparing base (05ab4bc) to head (7ea161e).
Report is 2 commits behind head on main.

Files Patch % Lines
feflow/utils/lambda_protocol.py 73.52% 9 Missing ⚠️
feflow/utils/data.py 60.00% 4 Missing ⚠️
feflow/protocols/nonequilibrium_cycling.py 97.53% 2 Missing ⚠️
feflow/settings/nonequilibrium_cycling.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   92.06%   86.18%   -5.89%     
==========================================
  Files           7        8       +1     
  Lines         416     1368     +952     
==========================================
+ Hits          383     1179     +796     
- Misses         33      189     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijpulidos ijpulidos requested a review from IAlibay March 9, 2024 04:05
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ijpulidos !
Only question I have is if you need a git-blame-ignore-revs file like this one? https://github.com/MDAnalysis/UserGuide/blob/develop/.git-blame-ignore-revs

@mikemhenry mikemhenry merged commit 7594295 into main Mar 11, 2024
5 checks passed
@mikemhenry mikemhenry deleted the feat/pre-commit-ci branch March 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants