-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run nightly Homebrew cron job only on the main repo, not on forks #4271
Run nightly Homebrew cron job only on the main repo, not on forks #4271
Conversation
I noticed this because GitHub emailed me that it would disable the nightly job because it hadn't changed for 3 months. It currently takes 30-50 minutes daily, and by default runs on all forks of the main repository that have the relevant workflow yaml file. That serves little purpose and wastes quite a bit of energy - so disable the runs outside of the main repo. This will not disable the runs on forks already made in the past that contain this workflow file, but it does save 3 months worth of runs on every new fork that is created. [skip ci]
Oops, that was rather excessive indeed. Thanks for fixing - I wonder if our other gh runners are similarly overzealous. |
I wonder if this happens everytime someone syncs their gh-hosted fork - even in preparation for creating a named branch for some future PR. (And I recently got some notifications that cirun jobs timed out after hours of waiting as there was no AWS worker configured for my personal account - probably worth looking into) |
Yes, I think it does indeed.
Those get triggered via Cirrus, and by default those trigger, unless:
I don't think any of those apply to the OpenBLAS repo at the moment? There's also the cost associated with running out of credits - not sure if you're worried about that. I've got a fair bit of experience with this now. Happy to sync some of the customizations from numpy/scipy to this repo if you think that's useful. |
Not sure I understand how Cirrus specifically would trigger a Cirun-based job (except that one recent occurence was from me updating cirrus.yml in a PR). Suspect it might be bc the workflow file for graviton also lacks an "if repository is the main one" conditional ? Certainly no harm done unless I manage to DDOS Cirun with spurious requests... |
This is a follow-up to OpenMathLibgh-4271. At the moment, when a contributor pushes the latest `develop` to their own branch to bring their own fork in sync with `main`, or if they push another branch, this triggers 30 CI jobs to run. Most will complete silently and only burn CPU time unnecessarily. If there's a failure, this may result in unexpected failure notifications. And the AWS Graviton3 run won't complete at all and time out, since the Cirun hook will only work when triggered from the main repo.
This is a follow-up to OpenMathLibgh-4271. At the moment, when a contributor pushes the latest `develop` to their own branch to bring their own fork in sync with `main`, or if they push another branch, this triggers 30 CI jobs to run. Most will complete silently and only burn CPU time unnecessarily. If there's a failure, this may result in unexpected failure notifications. And the AWS Graviton3 run won't complete at all and time out, since the Cirun hook will only work when triggered from the main repo.
Followed up on this now in gh-4305, sorry that took a while.
My bad, I confused this with the original plan about triggering via Cirrus - that's not the case, it triggers via the GitHub Actions app. |
I noticed this because GitHub emailed me that it would disable the nightly job because it hadn't changed for 3 months. It currently takes 30-50 minutes daily, and by default runs on all forks of the main repository that have the relevant workflow yaml file. That serves little purpose and wastes quite a bit of energy - so disable the runs outside of the main repo.
This will not disable the runs on forks already made in the past that contain this workflow file, but it does save 3 months worth of runs on every new fork that is created.
[skip ci]