Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve matcopy interface #4306

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Improve matcopy interface #4306

merged 1 commit into from
Nov 11, 2023

Conversation

angsch
Copy link
Contributor

@angsch angsch commented Nov 11, 2023

For most (all?) BLAS routines, matrices with zero-sized dimensions are valid inputs. [i,o]matcopy, however, stops with parameter number X has an illegal value when rows = 0 or cols = 0. This commit

  • allows matrices where the row or column count is zero (xerbla/info is no longer triggered)
  • adds a quick return path when at least one matrix dimension is zero
  • introduces the BLAS/LAPACK convention that the leading dimensions must be at least 1 (ie lda = 0, rows = 0 is illegal)

@angsch
Improve matcopy interface
5ffbe64 
* rows = 0 or cols = 0 is now a legal input and
  takes quick return path
* Follow BLAS/LAPACK convention that the leading
  dimensions must be at least 1.
@martin-frbg martin-frbg added this to the 0.3.25 milestone Nov 11, 2023
@martin-frbg martin-frbg merged commit 00ef1bb into OpenMathLib:develop Nov 11, 2023
63 checks passed
@martin-frbg martin-frbg mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.25
Development

Successfully merging this pull request may close these issues.
2 participants
@angsch @martin-frbg