Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add NO_UTEST #4543

Closed
wants to merge 1 commit into from
Closed

Makefile: add NO_UTEST #4543

wants to merge 1 commit into from

Conversation

ffontaine
Copy link
Contributor

Add NO_UTEST to allow the user to disable building utest

Add NO_UTEST to allow the user to disable building utest

Signed-off-by: Fabrice Fontaine <[email protected]>
@martin-frbg
Copy link
Collaborator

Thanks - I wonder why you would want to do this ?

@ffontaine
Copy link
Contributor Author

ffontaine commented Mar 8, 2024

Because utest unconditonally uses fork resulting in the following build failure on toolchain without MMU:

test_fork.c:(.text+0x120): undefined reference to `fork'

Full build log: http://autobuild.buildroot.org/results/b9d/b9d097ae077f2cb40fc60de94bf25423636af005/build-end.log

@martin-frbg
Copy link
Collaborator

I see, so it is actually this one test that should be excluded as not supported on your platform. Does the uclibc toolchain define anything that could be used to shortcut the fork test ? (Assuming that everything else needed by the OpenBLAS library itself is implemented)

@ffontaine
Copy link
Contributor Author

When MMU is disabled on an uclibc-ng toolchain, usr/include/bits/uClibc_config.h will contain:

#define __ARCH_HAS_MMU__ 1
#undef __ARCH_USE_MMU__

However, I still think that adding NO_UTEST is a better solution that adding uclibc-ng specific code to openblas. NO_UTEST could be used for example to speed up build time.
An other solution would be to add MMU dependency to openblas in buildroot.

@martin-frbg
Copy link
Collaborator

build should be fixed by #4544

@ffontaine
Copy link
Contributor Author

Thanks, however, test_post_fork.c shall also be patched to fully fix the build failure:

test_post_fork.c:(.text+0xb4): undefined reference to `fork'

@martin-frbg
Copy link
Collaborator

sorry for that, now addressed in #4546

@ffontaine
Copy link
Contributor Author

Thanks, build failure is fixed, closing this PR.

@ffontaine ffontaine closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants