Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated instanciate in favor of instantiation (correct grammatical form) #115

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

Eliott-Guevel
Copy link
Contributor

Deprecated instanciate in favor of instantiation (correct grammatical form). Same for instanciation which needs to be replaced by instantiation.
This commit fixes #97

Copy link
Member

@labordep labordep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old methods should return the new methods

src/Molecule/MolComponentFactory.class.st Show resolved Hide resolved
src/Molecule/MolComponentType.trait.st Show resolved Hide resolved
src/Molecule/MolHomeServices.class.st Show resolved Hide resolved
@Eliott-Guevel
Copy link
Contributor Author

Spaces can differ but I put back the code the way it was before my changes were applied

@labordep labordep changed the base branch from main to dev-97 October 24, 2023 10:49
@labordep
Copy link
Member

@Eliott-Guevel I move your PR into a dedicated dev branch to work on it

@labordep labordep merged commit 0f7f067 into OpenSmock:dev-97 Oct 24, 2023
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instanciate isn't the correct form
2 participants