Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAL] Initial push for pytest engine #273

Merged
merged 29 commits into from
Dec 18, 2024
Merged

[VAL] Initial push for pytest engine #273

merged 29 commits into from
Dec 18, 2024

Conversation

MateuszGrabuszynski
Copy link
Collaborator

Added as a PR to allow reviews. This PR should allow further development of pytest-based validation scenarios.

  • Moved the validation apps into .../tests/validation/application
  • Aligned docs to accommodate that change (.. added in README.md)
  • Added the necessary pytest engine files from internal repo (minimal viable set of them), files were reviewed briefly, headers aligned to BSD license with original authors' permission

@MateuszGrabuszynski MateuszGrabuszynski marked this pull request as draft November 28, 2024 12:30
marcin-le
marcin-le reviewed Nov 28, 2024
View reviewed changes
tests/validation/pytest/Engine/application_config.py Outdated Show resolved Hide resolved
tests/validation/pytest/Engine/ffmpeg_app.py Outdated Show resolved Hide resolved
tests/validation/pytest/Engine/fixtures.py Outdated Show resolved Hide resolved
KarolinaPomian
KarolinaPomian reviewed Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@KarolinaPomian KarolinaPomian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme for pytest would be usefull.

@MateuszGrabuszynski
Copy link
Collaborator Author

Readme for pytest would be usefull.

Great remark. Will start adding it at some point where the implementation is more stable (not sure when at the moment) :)

@MateuszGrabuszynski MateuszGrabuszynski changed the base branch from main to val-dev December 4, 2024 14:07
@MateuszGrabuszynski MateuszGrabuszynski marked this pull request as ready for review December 18, 2024 12:14
@MateuszGrabuszynski MateuszGrabuszynski merged commit 45364da into val-dev Dec 18, 2024
2 checks passed
@MateuszGrabuszynski MateuszGrabuszynski deleted the mcm-api-pytest branch December 18, 2024 12:23
MateuszGrabuszynski added a commit to zLukas/Media-Communications-Mesh that referenced this pull request Jan 15, 2025
@MateuszGrabuszynski @Falron98
@marcin-le @KarolinaPomian
[VAL] Initial push for pytest engine (OpenVisualCloud#273)
2cb4d11 
* Moving validation application into a separate folder
* Adding a base for functional testing using pytest
* Fixtures to build the newest validation app (Lappka)
* Class-based structure for JSON building

---------

Co-authored-by: Bartosz Krystowski <[email protected]>
Co-authored-by: marcin-le <[email protected]>
Co-authored-by: Pomian, Karolina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarolinaPomian KarolinaPomian KarolinaPomian left review comments

@marcin-le marcin-le marcin-le left review comments

@pwysock1-intel pwysock1-intel Awaiting requested review from pwysock1-intel

@soopel soopel Awaiting requested review from soopel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MateuszGrabuszynski @marcin-le @KarolinaPomian @Falron98 @ajanczew