Json support phase 1 #291
Closed
Json support phase 1 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tszumski
commented
Dec 16, 2024
•
tszumski
commented
- Fix compilation error on some configurations:
- Add nlohmann/json C++ json parser
- Parse json client config and connection config
- Add JSON configuration support for mesh client and connections
- Create JSON sender and receiver applications
- ST2110 bridges to take json parsed config
- Clone and modify sender/receiver sample app to support json
- Fix cmake/linker/grpc
- Add new 4 fields into MeshBuffer,
- Introduced setPayloadLen and setMetadataLen(partially) methods for MeshBuffer.
- Updated references from data_len and data to payload_len and payload_ptr across various files.
- Adjusted validation tests to reflect changes in buffer structure.
tszumski
force-pushed
the
tszumski-json-phase1
branch
2 times, most recently
from
86a06b5 to
0651d43
Compare
| VIDEO_FORMAT_YUV422P, ///< planar YUV 4:2:2, 16bpp | ||
| VIDEO_FORMAT_YUV422P10LE, ///< planar YUV 4:2:2, 20bpp | ||
| VIDEO_FORMAT_YUV444P10LE, ///< planar YUV 4:4:4, 30bpp | ||
| VIDEO_FORMAT_RGB8, ///< packed RGB 3:3:2, 8bpp |
There was a problem hiding this comment.
Do we really plan to support very lossy RGB8 (8bpp), or RGB24 (24bpp, 8-bit format)?
There was a problem hiding this comment.
FFmpeg describes RGB8 as 2:3:3. 3:3:2 is a BGR8.
IO... bgr8 3 8 3-3-2
Additionally, ST2110 does not support this format. The minimum is 8:8:8.
demangled = abi::__cxa_demangle(info.dli_sname, nullptr, 0, &status);
- Introduced setPayloadLen and setMetadataLen(partially) methods for MeshBuffer. - Updated references from data_len and data to payload_len and payload_ptr across various files. - Adjusted validation tests to reflect changes in buffer structure.
tszumski
force-pushed
the
tszumski-json-phase1
branch
from
2f6e0f5 to
e84d6f0
Compare
ko80
reviewed
Dec 18, 2024
sdk/CMakeLists.txt
Outdated
| @@ -41,6 +41,7 @@ set(MCMDP_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include) | |||
| set(MEMIF_DIR ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/libmemif) | |||
| set(MCMDP_SAMPLE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/samples) | |||
| set(PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../protos) | |||
| set(NLOHMANN_JSON_DIR ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/nlohmann) | |||
|
Closing, as #300 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.