Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MTL as sub-module and order documentation #297

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

skolelis
Copy link

Order documentation in MCM (and also BCS, MTL (in case MCM is used as sub-module)).
Add MTL as a submodule.

Order documentation in MCM (and also BCS, MTL (in case MCM is used as sub-module)).
Add MTL as a submodule.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal case the submodule should point to release tag.
I guess it is ok to point to some commit from main if release does not work
It cannot point to unmerged commit as it is now

As we talked before, merge everything to MTL before merging this one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to add tag to release after release. So far appointing "main" branch. According to @Mionsz suggestion.

@Sakoram
Copy link
Collaborator

Sakoram commented Dec 20, 2024

You added MTL as submodule, but

  • I don't see any changes to recommendation on how to clone the repo. I guess we need to clone recursively now.
  • I don't see any changes in build scripts. I guess we need to change how MTL is downloaded

PS. sorry for closing, it was a miss click

@Sakoram Sakoram closed this Dec 20, 2024
@Sakoram Sakoram reopened this Dec 20, 2024
@ko80 ko80 changed the title Add MTL as sub-module and order documenatation Add MTL as sub-module and order documentation Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants