Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend MCM API implementation in Media Proxy and SDK #306

Merged

Conversation

tszumski
Copy link
Collaborator

  1. Extend MCM API implementation in Media Proxy and SDK with new ST2110 Transport Pixel Format field
  2. Update MCM pixelFormat based on architect feedback

@tszumski tszumski requested a review from ko80 January 13, 2025 08:36
@tszumski tszumski force-pushed the tszumski-transport-format-api-adjustment branch from 5f7ed71 to a26476a Compare January 13, 2025 15:41
@ko80
Copy link
Collaborator

ko80 commented Jan 13, 2025

Are you going to add parsing of transportPixelFormat in parse_json()?

@ko80
Copy link
Collaborator

ko80 commented Jan 13, 2025

Please notice you need to update the video frame calculation in calc_payload_size() according to the introduced pixel format changes.

@tszumski
Copy link
Collaborator Author

Are you going to add parsing of transportPixelFormat in parse_json()?

Fixed in 9b32813

@tszumski
Copy link
Collaborator Author

Please notice you need to update the video frame calculation in calc_payload_size() according to the introduced pixel format changes.

Fixed in 9b32813

sdk/src/mesh_conn.cc Outdated Show resolved Hide resolved
@ko80
Copy link
Collaborator

ko80 commented Jan 14, 2025

Can you check if the traffic goes?

I'm getting an error reported by ST2110_20Tx->configure()
image

Command line:

sudo ffmpeg -stream_loop -1 -re -video_size 640x360 -pixel_format yuv422p10le -i netflix_crosswalk_640x360_60fps_10bit_le.yuv -f mcm -conn_type st2110 -transport st2110-20 -ip_addr 192.168.96.11 -port 9002 -frame_rate 60 -video_size 640x360 -pixel_format yuv422p10le -

@tszumski tszumski force-pushed the tszumski-transport-format-api-adjustment branch from 9b32813 to e2d027c Compare January 15, 2025 06:07
@tszumski
Copy link
Collaborator Author

Can you check if the traffic goes?

I'm getting an error reported by ST2110_20Tx->configure() image

Command line:

sudo ffmpeg -stream_loop -1 -re -video_size 640x360 -pixel_format yuv422p10le -i netflix_crosswalk_640x360_60fps_10bit_le.yuv -f mcm -conn_type st2110 -transport st2110-20 -ip_addr 192.168.96.11 -port 9002 -frame_rate 60 -video_size 640x360 -pixel_format yuv422p10le -

New parameter transport_format in configuration structure MeshConfig_ST2110 is not set to proper value, on my platform
it is set to "-1", while allowed value is 0 (macro MESH_CONN_ST2110_20_TRANSPORT_FMT_YUV422_10BIT). This structure comes from gRPC connection

@tszumski tszumski force-pushed the tszumski-transport-format-api-adjustment branch from fc90103 to 7467d32 Compare January 15, 2025 12:03
Copy link
Collaborator

@ko80 ko80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@moleksy moleksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@tszumski tszumski merged commit 96bfa1f into OpenVisualCloud:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants