feat(shared-data, api): Add evo tips definition and restrictions on loading #16710
+21,148
−3,218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laura-Danielle
force-pushed
the
PLAT-350-add-evo-tips-tiprack
branch
from
66da179 to
c87dde7
Compare
sfoster1
requested changes
Dec 10, 2024
| @@ -363,6 +372,27 @@ def ensure_definition_is_labware(definition: LabwareDefinition) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def ensure_labware_is_loadable( | |||
There was a problem hiding this comment.
This wants to be in the engine I reckon
Laura-Danielle
force-pushed
the
PLAT-350-add-evo-tips-tiprack
branch
from
bc3405e to
e01dcbe
Compare
Laura-Danielle
requested review from
smb2268 and
sfoster1
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16710 +/- ##
===========================================
- Coverage 92.43% 79.21% -13.23%
===========================================
Files 77 120 +43
Lines 1283 4533 +3250
===========================================
+ Hits 1186 3591 +2405
- Misses 97 942 +845
Flags with carried forward coverage won't be shown. Click here to find out more. |
sfoster1
approved these changes
Jan 7, 2025
Laura-Danielle
force-pushed
the
PLAT-350-add-evo-tips-tiprack
branch
from
51aafd4 to
b7536fc
Compare
…7183) * chore(shared-data): remove NODE_OPTIONS=--openssl-legacy-provider
…ma (#17196) This PR adds a new module type for the Flex Stacker in shared-data, module definition with some stubbed data and update the module schema so we can use reference this in other part of the code base.
Removes 40 or so warnings from tests on edge. Should be no functional change.
Matches the robot-side version.
* fix(protocol-designer): add align-items to title part
* chore(protocol-designer): remove * as React from react
* fix(protocol-designer): fix paddings in release note modal
* fix(protocol-designer): remove unused packages from pd
* fix(components, protocol-designer, app) fix some broken stories
* fix(protocol-designer): fix small condition issues
* fix(protocol-designer): unify time format to display the time
…start testing protocol actions in PD (#17156) <!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview These additions to the test case of transferSetting.js.cy are the start of providing greater test coverage to our transfer form. At this moment, it only goes up to saving a liquid and then opening the transfer form. <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> ## Test Plan and Hands on Testing These are changes exclusively to cypress. So it will be tested when folks run their code. <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog 1. opentrons/protocol-designer/cypress/e2e/transferSettings.cy.js . 2. opentrons/protocol-designer/cypress/support/commands.ts added some additional helper functions Please add special attention to checking if this was the correct way to add liquid. Saving it took a bit of extra effort. AFAIK > When you submit a form, the browser sends a POST or GET request to the action URL specified in the <form> tag or the current page URL if no action is defined. Cypress executes the test and observes the page reload, which can interfere with your test flow if you're not handling it properly. So I tried to do the following ```Javascript cy.contains('button', 'Add liquid').click() cy.contains('button', 'Liquid').click() cy.contains('button', 'Define a liquid').click() cy.get('input[name="name"]') // Select the input with name="name" .type('My liquid!') cy.get('div[aria-label="ModalShell_ModalArea"]') .find('form') // Target the form that wraps the button .invoke('submit', (e) => { e.preventDefault(); // Prevent default behavior }); ``` <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> ## Review requests @y3rsh @jerader <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment Medium. This might take some extra time with developers to ensure that I'm not breaking existing testing behavior. <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
… 4 (#17229) github actions upload-artifact and download-artifact v3 was deprecated so this updates to v4.
…ardware controller and robot server. (#17187)
Laura-Danielle
force-pushed
the
PLAT-350-add-evo-tips-tiprack
branch
from
23866ce to
37bc817
Compare
|
Rebase issues. Creating fresh branch to base off of chore release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add evo tips definition but as a labware so that liquid handling actions can happen in the 'labware'.
Test Plan and Hands on Testing
Need to check that the stackup works as expected
Changelog
Review requests
Check that the labware role makes sense and the stacking part.
Risk assessment
Low. Adding a new labware.