feat(api): add stacker module context and protocol command skeletons #17206
+1,569
−483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahiuchingau
force-pushed
the
EXEC-1079-module-context
branch
from
64c75d9 to
df3955a
Compare
ahiuchingau
commented
Jan 8, 2025
| @@ -54,5 +59,5 @@ | |||
| "AbsorbanceReader", | |||
| "AbsorbanceReaderStatus", | |||
| "AbsorbanceReaderDisconnectedError", | |||
| "ModuleDisconnectedCallback", | |||
There was a problem hiding this comment.
This modules.ModuleDisconnectedCallback type got removed as the type has not been mported to this file, and hence, will not affect the rest of the code
ahiuchingau
force-pushed
the
EXEC-1079-module-context
branch
from
df3955a to
69c76de
Compare
ahiuchingau
force-pushed
the
EXEC-1079-module-context
branch
from
69c76de to
aef78d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds flex stacker support skeleton in the protocol engine.
TODO: add this so seth doesn't yell at me later