feat(robot-server): Persist /labwareOffsets storage across reboots
#17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
commented
Jan 9, 2025
Comment on lines
+390
to
+392
| # Whether this record is "active", i.e. whether it should be considered as a | ||
| # candidate to apply to runs and affect actual robot motion: | ||
| sqlalchemy.Column("active", sqlalchemy.Boolean, nullable=False), |
There was a problem hiding this comment.
Is active a good name for this? Maybe valid, hidden, archived, ...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-1015.
Test plan and Hands on testing
We're covered by automated tests.
Changelog
labware_offsetSQL table.LabwareOffsetStoreto use it.Review requests
EXEC-1015 has a guideline:
The way I'm implementing that here is:
DELETErequests do an actual SQLDELETE.active, to represent the validity marking.TRUE, and there is currently no way of reading it.PATCH /labwareOffsets/{id} { "active": false }andGET /labwareOffsets?active=true.Does all of that sound right?
Risk assessment
Low. This code is currently unused.
If we need to make any changes to the SQL schema, it's possible to do later but kind of annoying, so we should scrutinize it here, to the extent that we can.