Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different slide reel prefabs #879

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Add different slide reel prefabs #879

merged 7 commits into from
Jun 4, 2024

Conversation

MegaPiggy
Copy link
Member

@MegaPiggy MegaPiggy commented Jun 2, 2024 •
edited
Loading

Minor features

  • New reelModel and reelCondition parameters in prop slideShows for slide reel mesh and material. (Full ring slide reel item prefab #811)
    • Models: 6-slided, 7-slided, 8-slided, and Whole (7-slided but connected like 8-slided).
    • Conditions: Antique (Stranger), Pristine (Dreamworld), Rusted (Burnt)
  • rotate parameter added to slide info. Rotates the slide reel item while inside a projector.

xen-42
xen-42 requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@xen-42 xen-42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get an NH Examples PR to go with this (in the Sequestered Luminary system since I want to rework the main system)

@MegaPiggy MegaPiggy mentioned this pull request Jun 4, 2024
Merged
@MegaPiggy
Copy link
Member Author

Can we get an NH Examples PR to go with this (in the Sequestered Luminary system since I want to rework the main system)

Ok I've done it

@MegaPiggy MegaPiggy requested a review from xen-42 June 4, 2024 09:14
@MegaPiggy MegaPiggy merged commit 7a44824 into dev Jun 4, 2024
2 checks passed
@MegaPiggy MegaPiggy deleted the slideReel branch June 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCorby JohnCorby JohnCorby approved these changes

@xen-42 xen-42 xen-42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MegaPiggy @xen-42 @JohnCorby @Bwc9876