-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize units #259
Standardize units #259
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 64.78% 65.19% +0.40%
==========================================
Files 14 15 +1
Lines 1045 1063 +18
==========================================
+ Hits 677 693 +16
- Misses 368 370 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Note that this supersedes #241 ; the tied-features component of which will be submitted as a separate PR after this gets merged. |
An extended version of this PR is now in #284. |
What
This introduces a new file
units.py
which standardizes the units for science-packs, and eventually for the entireFeatures
->Model
->Fitter
chain.Why
This will:
Features
tablesNote: we will convert any user input units into this format, and optionally convert tabulated/plotted output to the user's spectral units. But for specifying the PAHFIT science model to be fitted itself, these are the working units [1].
See this comment for information on how we can leverage
astropy.units
to understand user-input spectral units, e.g. to discriminate between flux density and spectral intensity (aka surface brightness).Proposed PAHFIT working + output units summary:
[1] Internally, fitters may adopt any different units for convenience or other reasons, but that is a hidden implementation detail. For the user, these will be the working units.
[2] These are already effectively standards in our science packs