Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the way to get default KMS for EBS #99

Conversation

sebastianczech
Copy link
Contributor

Description

PR fixes the way to get default KMS for EBS in all examples.

Motivation and Context

#98

How Has This Been Tested?

It was tested locally by executing terraform plan . If some of the owner can apply all examples using ChatOps, I would be grateful.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil
Copy link
Contributor

michalbil commented Jan 15, 2025

/apply paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 12779108662
Job result: FAILURE

@migara
Copy link
Member

migara commented Jan 16, 2025

@sebastianczech Thanks for the PR

@slawomir-kaczmarek slawomir-kaczmarek self-assigned this Jan 21, 2025
@slawomir-kaczmarek
Copy link
Contributor

Thank you Sebastian for the PR, the change is working fine as always ;) I just had to create a new PR where I left your change and made similar changes to VM-Series and Panorama modules on top of that, so I am closing this one.
#101

@sebastianczech sebastianczech deleted the fix/default-kms-ebs-alias branch January 22, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants