-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recomment not to commit .gitfat for S3 backend. #7
base: master
Are you sure you want to change the base?
Conversation
Just received an Email from amazon about compromized identity because .gitfat has been pushed to github!
@@ -80,7 +91,7 @@ First, we create a repository and configure it for use with `git-fat`. | |||
remote = localhost:/tmp/fat-store | |||
$ mkdir -p /tmp/fat-store # make sure the remote directory exists | |||
$ echo '*.gz filter=fat -crlf' > .gitattributes | |||
$ git add .gitfat .gitattributes | |||
$ git add .gitfat .gitattributes # do not add .gitfat if S3 backend is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rainwoodman maybe we use different .gitfat .gitfat_s3 to avoid this completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zelonght [email protected] writes:
@@ -80,7 +91,7 @@ First, we create a repository and configure it for use with
git-fat
.
remote = localhost:/tmp/fat-store
$ mkdir -p /tmp/fat-store # make sure the remote directory exists
$ echo '*.gz filter=fat -crlf' > .gitattributes
- $ git add .gitfat .gitattributes
- $ git add .gitfat .gitattributes # do not add .gitfat if S3 backend is used.
@rainwoodman maybe we use different .gitfat .gitfat_s3 to avoid this completely.
I'm not sure about this -- .gitfat
has something like 3 lines in it.
I don't think it would be worth splitting it into two separate files.
Ideally, I would like to run a command like
after cloning. The command would store to .git/config or to .git/fatconfig, which would never be committed to the repository. git-fat would then use the secrets stored in the following order: this supports 4 usecases:
|
I think we should be able to use something like https://www.kernel.org/pub/software/scm/git/docs/git-credential.html to manage the passwords. It will take a bit of fiddling (and perhaps a |
Looks reasonable! |
re: "It will take a bit of fiddling" -- I am ok with that as long as we can easily setup this (no problem with upgrading stuff). |
Just received an Email from amazon about compromized identity because .gitfat has been pushed to github!