Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Isaac topics configurable in URDF #38

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

MarqRazz
Copy link
Contributor

This PR makes it so the user can specify the topics that command and report state for the gripper in Isaac Sim.

@MarqRazz MarqRazz requested a review from moriarty October 14, 2023 13:49
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 420 lines in your changes are missing coverage. Please review.

Comparison is base (743d20f) 0.00% compared to head (2bf5f68) 20.77%.
Report is 7 commits behind head on main.

Files Patch % Lines
robotiq_driver/src/default_driver.cpp 9.09% 120 Missing ⚠️
robotiq_driver/src/hardware_interface.cpp 11.82% 64 Missing and 18 partials ⚠️
robotiq_driver/src/fake/fake_driver.cpp 0.00% 35 Missing ⚠️
robotiq_driver/src/default_serial.cpp 22.72% 32 Missing and 2 partials ⚠️
...botiq_driver/tests/test_default_driver_factory.cpp 34.28% 0 Missing and 23 partials ⚠️
robotiq_driver/src/default_driver_factory.cpp 26.66% 3 Missing and 19 partials ⚠️
robotiq_driver/src/default_serial_factory.cpp 29.16% 0 Missing and 17 partials ⚠️
..._controllers/src/robotiq_activation_controller.cpp 0.00% 15 Missing ⚠️
robotiq_driver/src/data_utils.cpp 55.88% 3 Missing and 12 partials ⚠️
...botiq_driver/tests/test_default_serial_factory.cpp 44.44% 0 Missing and 15 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #38       +/-   ##
==========================================
+ Coverage   0.00%   20.77%   +20.77%     
==========================================
  Files          5       20       +15     
  Lines        352      597      +245     
  Branches       0      240      +240     
==========================================
+ Hits           0      124      +124     
+ Misses       352      341       -11     
- Partials       0      132      +132     
Flag Coverage Δ
unittests 20.77% <21.34%> (+20.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarqRazz MarqRazz merged commit 1ec8f2a into main Nov 22, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the pr-param_isaac_topics branch November 22, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants