(ts) Runtime de-globalling (step 3) #6758
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbinding from an Android service is only an indication that the client no longer wants connected/disconnected events from the storage service, and that from the client's point of view, it is OK for the service to shut down. But it *doesn't* make any acquired bindings stop work. This means that we called close, and then called idle, which succeeds, since the binding still works. The `idle` call coming in after `onUnbind` was causing a store to get re-created (and then never cleaned up, since the binding in question would never be bound/unbound again). PiperOrigin-RevId: 346218079
… instead of accessing the StorageMeyManager.GLOBAL_INSTANCE directly. I've only updated some really simple usages to use the DI pattern. There shouldn't be any change in behaviour; everything still points to the global singleton instance for now. PiperOrigin-RevId: 346223334
add a comment saying it is a test for the generated entity classes use fixture entities test more field types PiperOrigin-RevId: 346237958
Coverage: 91.49% (inline protected method not covered, but tested indirectly) PiperOrigin-RevId: 346367830
These deps will be required soon due to a change in strict deps handling related to type aliases. Please do not remove these dependencies before b/169293220 is fixed, or risk breaking your build.
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:346364948:BASE:346351027:1607454378105:b69dba0a
PiperOrigin-RevId: 346386927
…est.kt with a comment saying it is a test for the generated references PiperOrigin-RevId: 346404540
PolymerLabs#6734) Closes PolymerLabs#6734 COPYBARA_INTEGRATE_REVIEW=PolymerLabs#6734 from mmandlis:schemafields-inline a00ce68 PiperOrigin-RevId: 346411248
… relationship between them. #codehealth PiperOrigin-RevId: 346417894
PiperOrigin-RevId: 346422565
PiperOrigin-RevId: 346436643
Add error message for CollectionHandle init Closes PolymerLabs#6690 COPYBARA_INTEGRATE_REVIEW=PolymerLabs#6690 from SHeimlich:collectionHandle dd7e309 PiperOrigin-RevId: 346455417
PiperOrigin-RevId: 346455476
The latter in particular removes a decent amount of complicated, unused logic. PiperOrigin-RevId: 346456956
PiperOrigin-RevId: 346459397
Due to the Copybara process, the correct import order is not always the same, so this lint check is proving to be very annoying.
…ll-deglobal-3 # Conflicts: # shells/tests/arcs/ts/runtime/arc-test.ts # shells/tests/arcs/ts/runtime/multiplexer-integration-test.ts # shells/tests/arcs/ts/runtime/plan-consumer-test.ts # shells/tests/arcs/ts/runtime/products-test.ts # shells/tests/arcs/ts/runtime/slot-composer-test.ts # shells/tests/arcs/ts/runtime/transformation-slots-test.ts # src/planning/plan/tests/plan-consumer-test.ts # src/planning/plan/tests/plan-producer-test.ts # src/planning/plan/tests/planificator-test.ts # src/planning/plan/tests/planning-result-test.ts # src/planning/plan/tests/test-environment-test.ts # src/planning/strategies/tests/coalesce-recipes-test.ts # src/planning/strategies/tests/search-tokens-to-handles-test.ts # src/planning/tests/planner-test.ts # src/runtime/recipe/tests/recipe-test.ts # src/runtime/runtime.ts # src/runtime/storage/drivers/driver-factory.ts # src/runtime/storage/tests/active-store-test.ts # src/runtime/storage/tests/direct-store-muxer-test.ts # src/runtime/storage/tests/firebase-store-integration-test.ts # src/runtime/storage/tests/ramdisk-direct-store-muxer-integration-test.ts # src/runtime/storage/tests/ramdisk-store-integration-test.ts # src/runtime/storage/tests/reference-mode-store-integration-test.ts # src/runtime/storage/tests/reference-mode-store-test.ts # src/runtime/storage/tests/storage-key-test.ts # src/runtime/storage/tests/store-sequence-test.ts # src/runtime/tests/arc-test.ts # src/runtime/tests/capabilities-resolver-test.ts # src/runtime/tests/manifest-test.ts # src/runtime/tests/runtime-test.ts # src/runtime/tests/test-environment-test.ts # src/tests/arc-integration-test.ts # src/tests/particles/common-test.ts # src/tests/particles/dataflow-test.ts # src/tests/particles/particles-test.ts # src/tests/recipe-descriptions-test.ts # src/tools/tests/allocator-recipe-resolver-test.ts # src/tools/tests/codegen-unit-test-base.ts # src/tools/tests/recipe2plan-test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.