-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: add bigger (and v6 enabled) bulk test on ubicloud #15018
Conversation
Pull Request Test Coverage Report for Build 12706379885Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
843748d
to
edc8f02
Compare
edc8f02
to
2c867d9
Compare
name: 'test rec ubicloud bulk' | ||
needs: | ||
- build-recursor | ||
runs-on: ubicloud-standard-8-ubuntu-2404 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this job uses Ubicloud runners, which may impact forks, I suggest adding a repository variable to check if Ubicloud runners are available. Something like BULK_TESTS_USE_UBICLOUD=1
(or a much better name) as a condition for running the job:
...
if: ${{ vars.BULK_TESTS_USE_UBICLOUD == '1' }}
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but how do I set this var in our own repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables are added at the repository level in Settings -> Secrets and Variables -> Actions -> Variables (tab) -> New Repository Variable
This has to be done by someone with enough privileges. I cannot see Settings for this repository, only for my fork. I have asked @Habbie for this in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I've set REC_BULKTEST_USE_UBICLOUD
to 1
, but the job is now skipped....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because vars are not set on PRs from a fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… get the vars from the pdns repo
69e680b
to
196a9a7
Compare
with c.cd('regression-tests'): | ||
c.run('curl -LO http://s3-us-west-1.amazonaws.com/umbrella-static/top-1m.csv.zip') | ||
c.run('curl --no-progress-meter -LO http://s3-us-west-1.amazonaws.com/umbrella-static/top-1m.csv.zip') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently discovered --process=dot:giga
(or mega
depending on size) which you might like
Short description
On ubicloud we do not run in a container any more, as it lacks v6 connectivity. We are running a debian executable on ubuntu, this is not causing any real issues (so far) except for some boost dependencies version mismatches. Luckily the boost packages required are available on ubuntu 24.04.
Current state of affairs:
Big (or medium) tsan tests do not work as they get killed due to excessive memory requirements (many TB virtual plus many GB resident).
Plan is to add a bigger version of the bulk test in daily. That one should use a auto-built recursor package.
Checklist
I have: