Add numpy to mypy check #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
…/columnar-dataset-python-mypy Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
mgovers
commented
Oct 1, 2024
mgovers
commented
Oct 1, 2024
mgovers
commented
Oct 1, 2024
figueroa1395
approved these changes
Oct 1, 2024
|
merging even though there are unresolved comments and pipeline is still running because it's to a base PR anyways |
…re/columnar-dataset-python-mypy Signed-off-by: Martijn Govers <[email protected]>
mgovers
merged commit 2a68c3d
into
feature/columnar-dataset-python-extension
12 of 24 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently, we did not check for numpy types, so a lot of the mypy errors in #699 were hidden