Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): old base image #148

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(build): old base image #148

wants to merge 4 commits into from

Conversation

jokesterfr
Copy link
Contributor

@jokesterfr jokesterfr commented Jan 9, 2025

Questions Answers
Description? Fix the build of images with old distros for PHP 5.6 and add more tests in the CI workflow.
Type? bug fix + enhancements
BC breaks? yes. CUSTOM_BASE_IMAGE has been removed, as this behavior is now configurable for both base and final images through TARGET_IMAGE or TARGET_IMAGE_NAME + TARGET_IMAGE_TAG (new)
Deprecations? no, but as the build script API change, please do not use CUSTOM_BASE_IMAGE nor --custom-base-image starting from now
Fixes PrestaShop 8.3 now proposes a parameters.yml.dist file. TARGET_IMAGE related fixes confusing with base image variables.
How to test? BASE_ONLY=true TARGET_PLATFORM=linux/arm64 PHP_VERSION=5.6 ./build.sh

@jokesterfr jokesterfr self-assigned this Jan 9, 2025
@jokesterfr jokesterfr added the ready to review Looking for a pair review label Jan 9, 2025
@jokesterfr
Copy link
Contributor Author

Should be good to go, will have a look at this next Tuesday.
I'm afraid some issues might raise with the new CI enforcements, will see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review Looking for a pair review
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants