refactor: remove guzzle dependency #468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/accounts-qc-php.yml # .zip-contents # Makefile # composer.json # composer.lock # config.local.php # config.preprod.php # config/admin/services.yml # config/common.yml # config/front/services.yml # ps_accounts.php
jokesterfr
reviewed
Jan 14, 2025
src/Api/Client/OAuth2/UserInfos.php
Outdated
| // [rat] => 1736251522 | ||
| // [sub] => 4rFN5bm2piPeYpsotUIwcyabcdeF | ||
| // ) [] [] | ||
| class UserInfos |
jokesterfr
reviewed
Jan 14, 2025
| @@ -56,7 +56,8 @@ public function execute(array $params = []) | |||
| $rsaKeysProvider = $this->module->getService(RsaKeysProvider::class); | |||
| try { | |||
| $rsaKeysProvider->cleanupKeys(); | |||
| $rsaKeysProvider->generateKeys(); | |||
| // FIXME: We MUST generate a new key here to avoid concurrent key re-generation at Presenter display time | |||
| //$rsaKeysProvider->generateKeys(); | |||
There was a problem hiding this comment.
should it be fixed in this PR?
jokesterfr
reviewed
Jan 14, 2025
| } catch (IdentityProviderException $e) { | ||
| $this->logger->error('error while executing middleware : ' . $e->getMessage()); | ||
| // } catch (IdentityProviderException $e) { | ||
| // $this->logger->error('error while executing middleware : ' . $e->getMessage()); |
jokesterfr
reviewed
Jan 14, 2025
src/Provider/ShopProvider.php
Outdated
| @@ -87,7 +87,8 @@ public function formatShopData(array $shopData, $psxName = '', $refreshTokens = | |||
|
|
|||
| // LinkAccount | |||
| 'uuid' => $linkShop->getShopUuid() ?: null, | |||
| 'publicKey' => $rsaKeyProvider->getOrGenerateAccountsRsaPublicKey() ?: null, | |||
| //'publicKey' => $rsaKeyProvider->getOrGenerateAccountsRsaPublicKey() ?: null, | |||
jokesterfr
reviewed
Jan 14, 2025
| @@ -66,7 +66,7 @@ public function itShouldSucceed() | |||
| $this->assertResponseDeleted($response); | |||
|
|
|||
| // FIXME: empty response | |||
| // $this->assertArraySubset(['success' => true], $json); | |||
| //$this->assertArraySubset(['success' => true], $json); | |||
There was a problem hiding this comment.
should it be removed then?
jokesterfr
reviewed
Jan 14, 2025
| 'objectResponse' => true, | ||
| 'allowRedirects' => true, | ||
|
|
||
| // 'base_uri' => $baseUrl, |
jokesterfr
reviewed
Jan 14, 2025
| @@ -173,10 +181,13 @@ public function assertResponseError($response) | |||
| */ | |||
| public function getResponseJson($response) | |||
| { | |||
| $ary = json_decode($response->getBody()->getContents(), true); | |||
| $response->getBody()->rewind(); | |||
| // FIXME | |||
jokesterfr
approved these changes
Jan 14, 2025
# Conflicts: # tests/Unit/Http/Client/CircuitBreaker/CircuitBreakerTest.php
# Conflicts: # src/Hook/ActionShopAccountUnlinkAfter.php # src/Provider/RsaKeysProvider.php # src/Provider/ShopProvider.php # src/Repository/ConfigurationRepository.php
# Conflicts: # _dev/package.json # config.xml # ps_accounts.php
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go a step further reducing friction with the PrestaShop module's ecosystem, reducing module weight.
As a module we just need to do a few things, not to embed huge libraries so let's get straight to the point and isolate a much a possible from other modules to avoid collisions, also stay lighter.
Still a POC, but fully functional.
Benefits: