Optimize onEditFilter

Before it always called ConfigJsonValidator::newInstance(), which reads a JSON file from disk. With a guard clause it is more efficient and more readable.
ProfessionalWiki · Jan 5, 2025 · 0a47a47 · 0a47a47
1 parent c0ac096
commit 0a47a47
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/EntryPoints/MediaWikiHooks.php b/src/EntryPoints/MediaWikiHooks.php
@@ -22,12 +22,13 @@ public static function onContentHandlerDefaultModelFor( Title $title, ?string &$
 	}
 
 	public static function onEditFilter( EditPage $editPage, ?string $text, ?string $section, string &$error ): void {
+		if ( !is_string( $text ) || !WikibaseExportExtension::getInstance()->isConfigTitle( $editPage->getTitle() ) ) {
+			return;
+		}
+
 		$validator = ConfigJsonValidator::newInstance();
 
-		if ( is_string( $text )
-			&& WikibaseExportExtension::getInstance()->isConfigTitle( $editPage->getTitle() )
-			&& !$validator->validate( $text )
-		) {
+		if ( !$validator->validate( $text ) ) {
 			$errors = $validator->getErrors();
 			$error = \Html::errorBox(
 				wfMessage( 'wikibase-export-config-invalid', count( $errors ) )->escaped() .