Notifications bug (#751)

* Updated CR boolean logic Signed-off-by: Joe Batt <[email protected]> * Added notification CR logic fix Signed-off-by: Joe Batt <[email protected]> --------- Signed-off-by: Joe Batt <[email protected]>
Project-MONAI · Apr 17, 2023 · 5297c24 · 5297c24
1 parent e972799
commit 5297c24
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/TaskManager/Plug-ins/AideClinicalReview/AideClinicalReviewPlugin.cs b/src/TaskManager/Plug-ins/AideClinicalReview/AideClinicalReviewPlugin.cs
@@ -88,9 +88,13 @@ private void Initialize()
                 _workflowName = Event.TaskPluginArguments[Keys.WorkflowName];
             }
 
-            if (Event.TaskPluginArguments.ContainsKey(Keys.Notifications))
+            if (Event.TaskPluginArguments.ContainsKey(Keys.Notifications) && Boolean.TryParse(Event.TaskPluginArguments[Keys.Notifications], out var result))
             {
-                _notifications = Boolean.TryParse(Event.TaskPluginArguments[Keys.Notifications], out bool result);
+                _notifications = result;
+            }
+            else
+            {
+                _notifications = true;
             }
 
             if (Event.TaskPluginArguments.ContainsKey(Keys.ReviewedExecutionId))

diff --git a/tests/IntegrationTests/TaskManager.IntegrationTests/Support/Assertions.cs b/tests/IntegrationTests/TaskManager.IntegrationTests/Support/Assertions.cs
@@ -40,12 +40,12 @@ public void AssertClinicalReviewEvent(ClinicalReviewRequestEvent clinicalReviewR
             clinicalReviewRequestEvent.PatientMetadata.PatientName.Should().Be(GetTaskPluginArguments(taskDispatchEvent, "patient_name"));
             clinicalReviewRequestEvent.PatientMetadata.PatientSex.Should().Be(GetTaskPluginArguments(taskDispatchEvent, "patient_sex"));
             clinicalReviewRequestEvent.PatientMetadata.PatientDob.Should().Be(GetTaskPluginArguments(taskDispatchEvent, "patient_dob"));
-            try
-            {
-                var notifications = GetTaskPluginArguments(taskDispatchEvent, "notifications");
 
+            if (Boolean.TryParse(GetTaskPluginArguments(taskDispatchEvent, "notifications"), out bool result))
+            {
+                clinicalReviewRequestEvent.Notifications.Should().Be(result);
             }
-            catch (Exception ex)
+            else
             {
                 clinicalReviewRequestEvent.Notifications.Should().Be(true);
             }