Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First round of upstreaming some improvements, mostly around
dependencies, from https://github.com/matthewhughes934/isort-fork
Update typing for
setuptools
The inspiration for this change was the following warning from
poetry
:Following that, adding
types-setuptools
allowed the removal of sometype: ignore
comments, which then lead to a single issue needing to befixed:
Remove some
flake8
exceptionsMostly as a matter of consistency. For
isort/__init__.py
thisexception looks to not be needed since
be0fbd0
An exception is kept in pace for an example file in tests as the
contents of the file are just for testing.
Restore
setuptools
as optional dependencyThis looks to have been accidentally removed with
f7a6b0e,
setuptools
is still requiredin
isort.setuptools_commands
Drop some unused dependencies
ipython
was removed with 49b41a5smmap2
looking at the history withgit log -G smmap --name-only --oneline
suggests this was only ever defined inpoetry.lock
/pyproject.toml
. Given this is a library and notproviding something extra like e.g. a
flake8
plugin it should besafe to remove