Defer starting the SAS session until needed #3448
Open
+33
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This resolves an issue with the SAS interface where the SAS session was being started in the interface
__init__.py
. This meant that any time the interface was created it immediately tried to connect - which, if you are offline, hung until the connection timed out (~10 seconds). With these changes (and some changes with how SAS tests are skipped), running the tests offline only hits the timeout once (and not a dozen times).Changes proposed in this PR:
available()
check or forsolve()
)available()
needed to be checked.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: