Skip to content

Commit

Permalink
Fix SOVERSION
Browse files Browse the repository at this point in the history
  • Loading branch information
@dantti
dantti committed Dec 30, 2024
1 parent fb6fcf1 commit 0eca9d6
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions QXlsx/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
cmake_minimum_required(VERSION 3.16)

project(QXlsx
VERSION 1.4.4
VERSION 1.5.0
LANGUAGES CXX
)

Expand All @@ -29,15 +29,15 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules)

if(NOT DEFINED QXLSX_PARENTPATH)
set(QXLSX_PARENTPATH ${CMAKE_CURRENT_SOURCE_DIR}/../)
set(QXLSX_PARENTPATH ${CMAKE_CURRENT_SOURCE_DIR}/../)
endif()

if(NOT DEFINED QXLSX_HEADERPATH)
set(QXLSX_HEADERPATH ${CMAKE_CURRENT_SOURCE_DIR}/../QXlsx/header/)
set(QXLSX_HEADERPATH ${CMAKE_CURRENT_SOURCE_DIR}/../QXlsx/header/)
endif()

if(NOT DEFINED QXLSX_SOURCEPATH)
set(QXLSX_SOURCEPATH ${CMAKE_CURRENT_SOURCE_DIR}/../QXlsx/source/)
set(QXLSX_SOURCEPATH ${CMAKE_CURRENT_SOURCE_DIR}/../QXlsx/source/)
endif()

# Due historical reasons this value is kept off
Expand Down Expand Up @@ -180,7 +180,7 @@ PUBLIC
set_target_properties(QXlsx PROPERTIES
OUTPUT_NAME ${EXPORT_NAME}
VERSION ${PROJECT_VERSION}
SOVERSION 0.${PROJECT_VERSION}

This comment has been minimized.

Sign in to view

Copy link
@DarthGandalf

DarthGandalf Dec 31, 2024

Contributor

This contradicts what you wrote in #375

This line is claiming that 1.5.0 is ABI-compatible with any other 1.x.x

This comment has been minimized.

Sign in to view

Copy link
@dantti

dantti Dec 31, 2024

Author Member

well 0.1.4.4 should not match 1.

This comment has been minimized.

Sign in to view

Copy link
@DarthGandalf

DarthGandalf Dec 31, 2024

Contributor

Of course. But for future versions, e.g. 1.6.0 or 1.5.1, with this formula, they would still be "1", despite you saying that the library is volatile

This comment has been minimized.

Sign in to view

Copy link
@dantti

dantti Dec 31, 2024

Author Member

Right, but if we were to update SOVERSION more regularly the proper thing is to update the major version.

This comment has been minimized.

Sign in to view

Copy link
@DarthGandalf

DarthGandalf Dec 31, 2024

Contributor

Alright. Though I'd say updating major version is more like breaking API than ABI
SOVERSION ${PROJECT_VERSION_MAJOR}
PUBLIC_HEADER "${QXLSX_PUBLIC_HEADERS}"
)

Expand Down

0 comments on commit 0eca9d6

Please sign in to comment.