Implement app subscriptions #111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnotherZane
commented
May 14, 2024
Comment on lines
+20
to
+23
| Snowflake applicationId, int limit = Discord.Limits.Rest.FetchEntitlementsPageSize, | ||
| Snowflake? userId = null, Snowflake[]? skuIds = null, | ||
| Snowflake? beforeId = null, Snowflake? afterId = null, | ||
| Snowflake? guildId = null, bool excludeEnded = false, |
There was a problem hiding this comment.
I'm not sure if before and after here are mutually exclusive since it's not documented and I have no way to test it. Hence, I'm not using fetch direction here, would require someone with a verified bot to test it.
Ideally userId and guildId should also be mutually exclusive and we would use ownerId and ownerType, similar to the json parameters used by the Create Test Entitlement endpoint. However, once again there is no documentation specifying such, so I've let it be as is.
AnotherZane
commented
May 14, 2024
| Purchase = 1, | ||
|
|
||
| /// <summary> | ||
| /// The entitlement was a part of a Discord Nitro subscription. |
There was a problem hiding this comment.
Not so sure about this description, the docs aren't very clear about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented SKUs and Entitlements as a part of App Subscriptions.
Changelog Ref:
Checklist