Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The undeposit just withdraws the LP and not call the claim function #1645

Closed
wants to merge 1 commit into from
Closed

The undeposit just withdraws the LP and not call the claim function #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/StakerMyStakes/FarmStakeButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function FarmStakeButtons({ el }: FarmCardDetailProps) {
const { txType, selectedTokenId, txConfirmed, txError, selectedFarmingType } =
v3Stake ?? {};

const { eternalCollectRewardHandler, withdrawHandler, claimRewardsHandler } =
const { eternalCollectRewardHandler, withdrawHandler, exitFarmingsHandler } =
useFarmingHandlers() || {};

return (
Expand Down Expand Up @@ -80,18 +80,18 @@ export default function FarmStakeButtons({ el }: FarmCardDetailProps) {
disabled={
selectedTokenId === el.id &&
selectedFarmingType === FarmingType.ETERNAL &&
txType === 'claimRewards' &&
txType === 'exitFarmings' &&
!txConfirmed &&
!txError
}
onClick={() => {
claimRewardsHandler(el.id, { ...el }, FarmingType.ETERNAL);
exitFarmingsHandler(el.id, { ...el }, FarmingType.ETERNAL);
}}
>
<small>
{selectedTokenId === el.id &&
selectedFarmingType === FarmingType.ETERNAL &&
txType === 'claimRewards' &&
txType === 'exitFarmings' &&
!txConfirmed &&
!txError
? t('undepositing')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Overview

The provided code patch modifies a component named FarmStakeButtons in a React application that interacts with a farming reward system. Specifically, it replaces the handling of a claim rewards action with an exit farming action.

Changes Made

  1. Renaming of Handlers: The handler for claiming rewards has been changed to a handler for exiting farmings.
  2. Condition Updates: The conditional logic for handling button states has been modified to reflect the new action, transitioning from claimRewards to exitFarmings.

Bug Risks

  1. Handler Existence: Ensure that exitFarmingsHandler is correctly implemented in the useFarmingHandlers hook and that it behaves as expected. If it is undefined or lacks proper error handling, it may lead to runtime errors.
  2. State Management: Verify that the state that determines txType and the related txError and txConfirmed booleans correctly aligns with the new exit action. The wrong state could lead to incorrect button disabled states or unresponsive buttons.
  3. Function Calls: Ensure that exitFarmingsHandler(el.id, { ...el }, FarmingType.ETERNAL); has the correct parameters, especially if the handler requires data structure similar to the previous claim handler. Mismatches could cause unexpected results.
  4. Localization: The text shown in the button (t('undepositing')) implies withdrawal or a similar action. Make sure this text makes sense in the context of exiting farmings.

Improvement Suggestions

  1. Error Handling: Consider adding error handling around the exitFarmingsHandler invocation to gracefully manage any issues that arise during the exit process.
  2. User Feedback: If the actions might take a while, consider adding a loading indicator or disabling the button while the transaction is in progress to enhance user experience.
  3. Type Safety: Ensure that TypeScript types are strictly enforced on exitFarmingsHandler and related states to prevent potential runtime issues.
  4. Documentation: Add comments or documentation to clarify the purpose of the change, especially for future maintainers who may not be familiar with the specific transition from claiming rewards to exiting farmings.
  5. Testing: Ensure that unit tests cover both successful and error scenarios for the exit farming action to maintain code reliability.

Conclusion

The patch seems straightforward, but careful attention should be paid to the new handler's implementation and its integration with the overall state management and user experience. Proper testing and validation will be essential to ensure the new functionality works as intended without introducing any bugs.

Expand Down
61 changes: 3 additions & 58 deletions src/hooks/useStakerHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function useFarmingHandlers() {
const { updateV3Stake } = useV3StakeData();

//exit from basic farming and claim than
const claimRewardsHandler = useCallback(
const exitFarmingsHandler = useCallback(
async (
token: any,
{
Expand All @@ -43,10 +43,6 @@ export function useFarmingHandlers() {
eternalBonusRewardToken,
eternalStartTime,
eternalEndTime,
eternalBonusEarned,
eternalEarned,
limitBonusEarned,
limitEarned,
isDetached,
}: any,
farmingType: any,
Expand All @@ -56,19 +52,12 @@ export function useFarmingHandlers() {
updateV3Stake({
selectedTokenId: token,
selectedFarmingType: farmingType,
txType: 'claimRewards',
txType: 'exitFarmings',
txConfirmed: false,
txHash: '',
txError: '',
});

const MaxUint128 = toHex(
JSBI.subtract(
JSBI.exponentiate(JSBI.BigInt(2), JSBI.BigInt(128)),
JSBI.BigInt(1),
),
);

const farmingCenterContract = new Contract(
FARMING_CENTER[chainId],
FARMING_CENTER_ABI,
Expand All @@ -95,28 +84,6 @@ export function useFarmingHandlers() {
]),
];

if (Boolean(+eternalEarned)) {
callDatas.push(
farmingCenterInterface.encodeFunctionData('claimReward', [
eternalRewardToken.address,
account,
0,
MaxUint128,
]),
);
}

if (Boolean(+eternalBonusEarned)) {
callDatas.push(
farmingCenterInterface.encodeFunctionData('claimReward', [
eternalBonusRewardToken.address,
account,
0,
MaxUint128,
]),
);
}

if (isDetached) {
const estimatedGas = await farmingCenterContract.estimateGas.multicall(
callDatas,
Expand Down Expand Up @@ -169,28 +136,6 @@ export function useFarmingHandlers() {
]),
];

if (Boolean(+limitEarned)) {
callDatas.push(
farmingCenterInterface.encodeFunctionData('claimReward', [
limitRewardToken.address,
account,
MaxUint128,
0,
]),
);
}

if (Boolean(+limitBonusEarned)) {
callDatas.push(
farmingCenterInterface.encodeFunctionData('claimReward', [
limitBonusRewardToken.address,
account,
MaxUint128,
0,
]),
);
}

const estimatedGas = await farmingCenterContract.estimateGas.multicall(
callDatas,
);
Expand Down Expand Up @@ -663,7 +608,7 @@ export function useFarmingHandlers() {
approveHandler,
farmHandler,
withdrawHandler,
claimRewardsHandler,
exitFarmingsHandler,
eternalCollectRewardHandler,
eternalOnlyCollectRewardHandler,
};
Expand Down
Loading