Skip to content

Commit

Permalink
Merge branch 'main' into prepare-spatial-filter-revisions
Browse files Browse the repository at this point in the history
  • Loading branch information
JosiahParry authored Oct 29, 2024
2 parents dbb1588 + fadc050 commit a16246e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
12 changes: 8 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
# arcgislayers (development version)

## Breaking changes

- `dplyr` methods for `collect()`, `select()`, and `filter()` have been removed. <https://github.com/R-ArcGIS/arcgislayers/issues/111> <https://github.com/R-ArcGIS/arcgislayers/issues/224> <https://github.com/R-ArcGIS/arcgislayers/issues/218>

## New features

- Improve handling of `filter_geom` by `arc_select()` by warning if applying `sf::st_union()` to the filter does not generate a length 1 sfc, or if `filter_geom` is supplied when accessing a Table, or if `filter_geom` is empty (@elipousson, #166)

## Bug fixes

- `arc_select()` includes argument name in error message when `...` contains non-string values. <https://github.com/R-ArcGIS/arcgislayers/issues/226>

## Breaking changes

- `dplyr` methods for `collect()`, `select()`, and `filter()` have been removed. <https://github.com/R-ArcGIS/arcgislayers/issues/111> <https://github.com/R-ArcGIS/arcgislayers/issues/224> <https://github.com/R-ArcGIS/arcgislayers/issues/218>

# arcgislayers 0.3.1

## Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion R/arc-select.R
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ arc_select <- function(
key <- dots_names[i]
val <- dots[[i]]
# check that the value is a scalar and non-empty
check_string(val, allow_empty = FALSE)
check_string(val, arg = key, allow_empty = FALSE)

# insert into query
query[[key]] <- val
Expand Down

0 comments on commit a16246e

Please sign in to comment.