Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the address of keychain internal also tweak #273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Crayon-Shin-chan-bitlightlabs

We integrated the taproot advanced script with RGB, such as HTLC script. When we perform refund or redeem operations, we need to transfer the corresponding BTC to the keychain internal that bp wallet will known these utxos

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 2.8%. Comparing base (55a814a) to head (b08fdfa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/descriptor.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #273     +/-   ##
=======================================
- Coverage     2.8%   2.8%   -0.0%     
=======================================
  Files          15     15             
  Lines        1914   1921      +7     
=======================================
  Hits           53     53             
- Misses       1861   1868      +7     
Flag Coverage Δ
rust 2.8% <0.0%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@St333p
Copy link

St333p commented Jan 14, 2025

I don't see issues with this proposal, as there may be cases in which it's necessary to add the tapret tweak on an output whose address doesn't belong to the tapret keychain. I'd even argue we could skip the check on the keychain altogether, giving more freedom to wallet developers to manage keychains as they see fit. Those not needing the additional freedom can always avoid receiving on tweaked addresses belonging to unexpected keychains.

@dr-orlovsky
Copy link
Member

Yes, let's skip the check altogether then. Also, in v0.12 there is no such thing anyway

@dr-orlovsky
Copy link
Member

Why did you close the PR? It was fine, you've could just add a commit removing the check on top...

@Crayon-Shin-chan-bitlightlabs
Copy link
Author

Why did you close the PR? It was fine, you've could just add a commit removing the check on top...

i have tried to fix it, but the deprecated strict_serialize_type i can't fix. because that need to modify the upstream strict_types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants