Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning the use of the proper stream in allreduce #382

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Jan 23, 2025

A regression for ROCm from upstream https://github.com/vllm-project/vllm/pull/11870/files#diff-cf486d32b11454e89103000ac0f9a93ee1ccbb8983c02e794b734a65301cd98bR360
Doesn't seem to affect CUDA, but further investigation needed

@gshtras gshtras merged commit 5f9b40b into main Jan 23, 2025
1 of 2 checks passed
@gshtras gshtras deleted the bring_stream_back branch January 23, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants