-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newsletter #263
Add newsletter #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me
Thanks @twinkarma - plan is not to merge until newsletter content is done. |
I should change this to use collections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collection based implementation is working nicely.
There is an issue with the navigation bar at certain horizontal resolutions, where it overlaps onto 2 rows rather than folding down to the mobile nav.
Either need to reduce the total number of top level items, or change the breakpoint for navigation compaction.
The easiest solution is probably to just fold newsletter into the RSE Community heading?
The PR to add the uni logo to the navbar would probably exacerbate this (and might need fixing independantly regardless)
Thanks @ptheywood and @twinkarma - maybe worth considering in relation to #257. The whole RSE Community section needs review as well. This may change the headings / organisation thereof. |
Community section review now #264 |
I've added newsletter content. |
|
Maybe worth mentioning that Fariba is part of TUOS ML group. |
Following the general approval and incorporation of comments from yesterdays training meeting (20200701), I'm merging. Email out to Google list will follow. |
Adds newsletter section to site, initial newsletter.