Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter #263

Merged
merged 16 commits into from
Jul 2, 2020
Merged

Add newsletter #263

merged 16 commits into from
Jul 2, 2020

Conversation

bobturneruk
Copy link
Collaborator

Adds newsletter section to site, initial newsletter.

Copy link
Contributor

@twinkarma twinkarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me

@bobturneruk
Copy link
Collaborator Author

Thanks @twinkarma - plan is not to merge until newsletter content is done.

@bobturneruk
Copy link
Collaborator Author

I should change this to use collections.

Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collection based implementation is working nicely.

There is an issue with the navigation bar at certain horizontal resolutions, where it overlaps onto 2 rows rather than folding down to the mobile nav.

Either need to reduce the total number of top level items, or change the breakpoint for navigation compaction.

image

The easiest solution is probably to just fold newsletter into the RSE Community heading?
The PR to add the uni logo to the navbar would probably exacerbate this (and might need fixing independantly regardless)

@bobturneruk
Copy link
Collaborator Author

Thanks @ptheywood and @twinkarma - maybe worth considering in relation to #257. The whole RSE Community section needs review as well. This may change the headings / organisation thereof.

@bobturneruk
Copy link
Collaborator Author

Community section review now #264

@bobturneruk
Copy link
Collaborator Author

I've added newsletter content.

@bobturneruk bobturneruk requested review from ptheywood, twinkarma and a team and removed request for ptheywood and twinkarma June 29, 2020 08:27
@willfurnass willfurnass mentioned this pull request Jul 1, 2020
@bobturneruk
Copy link
Collaborator Author

  • EPSRC webinar

@willfurnass
Copy link
Collaborator

Maybe worth mentioning that Fariba is part of TUOS ML group.

@bobturneruk bobturneruk marked this pull request as ready for review July 2, 2020 08:21
@bobturneruk
Copy link
Collaborator Author

Following the general approval and incorporation of comments from yesterdays training meeting (20200701), I'm merging. Email out to Google list will follow.

@bobturneruk bobturneruk merged commit c52294a into master Jul 2, 2020
@bobturneruk bobturneruk deleted the newsletter branch July 2, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants