Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html::scroll-padding-top:80px to css #842

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add html::scroll-padding-top:80px to css #842

merged 1 commit into from
Nov 25, 2024

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Nov 25, 2024

Haven't tested this is actually the right place to inject the css rule, but should be fine (worst case it has no effect here).

Closes #841

Haven't tested this is actually the right place to inject the css rule, but should be fine (worst case it has no effect here).

Closes #841
Copy link
Member

@martinjohndyer martinjohndyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Robadob, that looks a lot better to me!

@Robadob Robadob merged commit cfcfbc3 into master Nov 25, 2024
2 checks passed
@Robadob Robadob deleted the Robadob-patch-1 branch November 25, 2024 14:08
@ptheywood
Copy link
Member

The fixed 80px value seems fine with current other CSS rules, but this will need updating if other css / logo images are made which impact the nav header.

Currently 2* 10px of padding from .header, 10px from .header .logo, and then I think the height of a h1 in the navbar (from h1 line-height: 1.2 and .header .logo font-size: 32px, plus something else?

Either way, its not based on css variables so an arbitrary absolute value would have to be used anyway, just we might have to adjust it in the future, and if users have their own accessibillity CSS it might not have the correct value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section titles are hidden behind the top bar when directly linked
3 participants