Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes repetitive wording #860

Merged
merged 2 commits into from
Jan 6, 2025
Merged

chore: removes repetitive wording #860

merged 2 commits into from
Jan 6, 2025

Conversation

ns-rse
Copy link
Contributor

@ns-rse ns-rse commented Jan 6, 2025

No description provided.

@ns-rse ns-rse requested a review from a team January 6, 2025 08:55
@Robadob
Copy link
Member

Robadob commented Jan 6, 2025

CI isn't happy though 🤷‍♂️

@ptheywood
Copy link
Member

Pa11y-ci seems to have become stale, which given it's a nodejs project is probably not a good thing and might be the cause of the issue (i.e. some incompatible dependencies after chromium/puppeteeer updates?)

Someone has forked pa11y-ci and updated dependencies / released newer versions (https://github.com/aarongoldenthal/pa11y-ci / https://www.npmjs.com/package/@aarongoldenthal/pa11y-ci) which might resolve things?

I'll try it in a branch.

@ptheywood
Copy link
Member

Switching to the fork didn't resolve the issue, but did give a slightly more helpful error message from chromium.

ubuntu-latest has changed from being 22.04 to 24.04 between this run last being successful / not being successful (and is mentioned as a warning on the last working run of the workflow 3 weeks ago)

image

Explicitly using ubuntu-2204 is likely the simplest fix (until something else breaks). I'll make a change in this PR once tested separately.

pa11y-ci uses old versions of chromium & puppeteer which does not agree with the kernel, used in Ubuntu 24.04. Explicitly using the older Ubuntu is the simplest fix (and should be supported until 2027)
@ptheywood
Copy link
Member

CI is now passing on this workflow (but not sure pa11y is actually working & might not have done for a while, but that's a separate problem).

@ns-rse
Copy link
Contributor Author

ns-rse commented Jan 6, 2025

Thanks @ptheywood 👍

ubuntu-latest has changed from being 22.04 to 24.04 between this run last being successful / not being successful (and is mentioned as a warning on the last working run of the workflow 3 weeks ago)

Doesn't look like the cause here but R and I don't recall seeing anywhere that uses R markdown but R is no longer bundled in 24.04 and would require explicit installation after spinning up. This might impact the Handbook though after David translated it to Quarto. I'll check and make sure that doesn't break.

@ns-rse ns-rse merged commit e0c9ba1 into master Jan 6, 2025
2 checks passed
@ns-rse ns-rse deleted the ns-rse/tidy-profile branch January 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants