-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lightdom css controller #2057
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +502 B (+0.24%) Total Size: 208 kB
ℹ️ View Unchanged
|
1831ee3
to
bb6b66e
Compare
Doing this causes FOUC on rh-table at load. I don't see this as a desired effect. rh-table.movI'm questioning how loading the styles via javascript in this case would be helpful to the end user seems likely it would only reduce the need for an implementer to add a It may also be I need more time to process how we divide up the -lightdom.css and -lightdom-shim.css files and which get loaded via this controller. |
yes, as mentioned in chat, I'm aware of the fouc, and as i wrote in the description i'm working on an ssr solution lightdom css is part of the element definition. meaning that the element does not work if you don't have it's associated lightdom css. What this PR solves (as discussed at length in many places over several months) is
Hope that clarifies |
What I did
LightdomCSSController
which auto-loads lightdom css--_rhds-lightdom: rh-table
brand to the table lightdom stylesheet (required for the controller to work efficiently)Testing Instructions
Notes to Reviewers
The SSR story has yet TBD, it may be possible to automatically write lightdom sheets as styletags via the controller / element renderer