Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing space from license URL and end of lines #11

Merged

Conversation

DavidBiesack
Copy link
Contributor

What/Why/How?

Fixes #10

Reference

N/A

Testing

$ spectral lint -r ~/.spectral.yaml openapi.yaml 
No results with a severity of 'error' found!

Screenshots (optional)

Check yourself

  • Code is linted
    • I linted with spectral
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
    • unsure how to do this - add info to README.md or a contributors guidelines file?

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines
    • unsure how to verify this - no guidelines in README.md

@samchon samchon mentioned this pull request Apr 4, 2024
@samchon
Copy link

samchon commented Apr 4, 2024

https://nestia.io/docs/editor/

Tried to convert your openapi.yaml to TypeScript SDK, and failed due to type assertion. The type assertion error message was ``info.license.urlis not following theuriformat, and found that the property value was a little bit weird. Theurl` value must be trimmed without any space.

This PR fixes the spaced url value, so that would be succeeded to convert to the TypeScript SDK like below.

https://stackblitz.com/edit/pqln74?file=README.md,test%2Fstart.ts&startScript=swagger&startScript=hello

@lornajane lornajane self-requested a review April 5, 2024 12:49
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavidBiesack !

@lornajane lornajane merged commit a5db560 into Redocly:main Apr 5, 2024
1 check passed
@lornajane
Copy link
Contributor

(also thanks @samchon , I realise you also fixed the same thing because I was too slow to review and merge this one :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

license URL has trailing space
3 participants