Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some objects didn't have a clear type described #27

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

lornajane
Copy link
Contributor

What/Why/How?

While evaluating Redocly/redocly-cli-cookbook#33 I realised that our own API description didn't have types on all components. Added the ones that the check picked up.

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@lornajane lornajane requested a review from a team April 26, 2024 10:43
@lornajane lornajane marked this pull request as ready for review April 26, 2024 10:44
@lornajane lornajane merged commit e6c64b4 into main Apr 26, 2024
2 checks passed
@lornajane lornajane deleted the clarify-schema-types branch April 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants