Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset id when adding a local dir with trailing slash #208

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix dataset id when adding a local dir with trailing slash #208

merged 2 commits into from
Dec 10, 2024

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented Dec 9, 2024

See #206 (comment)

Minimally:

>>> from rocrate.rocrate import ROCrate
>>> crate = ROCrate()
>>> folder = crate.add_dataset("folder/")
>>> folder.id
'#7e28c8e2-54ef-4c2e-af09-3bcbaaa986e3'

@simleo simleo merged commit 1679a24 into ResearchObject:master Dec 10, 2024
12 checks passed
@simleo simleo deleted the fix_dir_id branch December 10, 2024 10:21
@simleo simleo mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simleo