Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort cheaper offers first #1613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sort cheaper offers first #1613

wants to merge 1 commit into from

Conversation

fiatjaf
Copy link
Contributor

@fiatjaf fiatjaf commented Nov 11, 2024

I've tried to run it locally but failed, so I don't know if this works.

@KoalaSat
Copy link
Member

@fiatjaf It's cheap in case you are buyer, but not if you are seller 😃

Maybe we can automatically modify that sorting if you filter by SELL or BUY?

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Nov 13, 2024

Anything is better than sorting by the order host, right?

@Reckless-Satoshi
Copy link
Collaborator

Indeed, we should improve the sorting.

I believe ordering by coordinator probably has no effect on the willingness to coordinate, but sorting by coordinator is the only "perk" coordinators get when they donate some sats to the development of the project (TLDR; slightly higher chance to show on top correlates to their stated voluntary devfund contribution. Coordinators that donate 0 will still show on top, it is just less likely.).

In order to not break coordinator expectations, what about we first try hierarchical sorting. Factor 1. order host, factor 2. cheapness (accounting for whether it's a "buy" or "sell"). Maybe overly complicated...?

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Nov 24, 2024

Honestly the first time I browsed this I was so confused because I assumed it was sorted by price and then I only saw some very high prices and I thought the liquidity of the app was awful because the best price options were all on the third page, so I opened this.

I didn't know this was by design as a perk for coordinators. But thinking now I don't think this makes sense as a perk either.

A better perk would be to default the coordinator at order creation time to the top coordinators. That will probably have a much bigger impact on coordinator usage.

Maybe you're doing this already? How do you select what is the default coordinator when creating an order?

If you have coordinators order by total contributions, like

  1. Coordinator A: 60% of contributions
  2. Coordinator B: 30% of contributions
  3. Coordinator C: 10% of contributions

then you could make A be the default preselected coordinator 60% of the times, B 30% of the times etc (by using a random function with probabilities on the client side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants