-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some additional tools to the CI #3275
base: master
Are you sure you want to change the base?
Conversation
8522432
to
4e3793d
Compare
5e163b4
to
2a1b269
Compare
jobs: | ||
compilation-database: | ||
env: | ||
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can probably go away
include-what-you-use: | ||
needs: compilation-database | ||
env: | ||
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto 😬
The build probably has to be parallelized in order to complete in time |
Bear doesn't like parallel jobs, IIRC there is a race condition on the jobserver, compiling from scratch with only one job shouldn't take that much time, at most 1h. Here we hit another bug in bear, which makes bear hang indefinitely even if the compilation was done. I'll probably get rid of bear anyway, I thought it would be great to have compilation database artifacts around but they are not as useful as I initially thought and I do not want to fight bear indefinitely. |
ChangeLog: * .github/workflows/lint.yml: New file. * .github/clang-tidy.yml: New file. Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
Add clang-tidy and iwyu