Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some additional tools to the CI #3275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Nov 27, 2024

Add clang-tidy and iwyu

@P-E-P P-E-P force-pushed the clang-tidy branch 7 times, most recently from 8522432 to 4e3793d Compare November 28, 2024 11:51
@P-E-P P-E-P marked this pull request as ready for review November 28, 2024 12:00
@P-E-P P-E-P added the CI label Nov 28, 2024
@P-E-P P-E-P force-pushed the clang-tidy branch 3 times, most recently from 5e163b4 to 2a1b269 Compare November 29, 2024 11:07
jobs:
compilation-database:
env:
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can probably go away

include-what-you-use:
needs: compilation-database
env:
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto 😬

@powerboat9
Copy link
Contributor

The build probably has to be parallelized in order to complete in time

@P-E-P
Copy link
Member Author

P-E-P commented Dec 2, 2024

The build probably has to be parallelized in order to complete in time

Bear doesn't like parallel jobs, IIRC there is a race condition on the jobserver, compiling from scratch with only one job shouldn't take that much time, at most 1h.

Here we hit another bug in bear, which makes bear hang indefinitely even if the compilation was done.

I'll probably get rid of bear anyway, I thought it would be great to have compilation database artifacts around but they are not as useful as I initially thought and I do not want to fight bear indefinitely.

ChangeLog:

	* .github/workflows/lint.yml: New file.
	* .github/clang-tidy.yml: New file.

Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants