chore: try fixing tests

SAP · Jan 16, 2025 · 500822c · 500822c
1 parent 59ae014
commit 500822c
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 12 deletions.
diff --git a/packages/odata-v4/src/de-serializers/converters.ts b/packages/odata-v4/src/de-serializers/converters.ts
@@ -52,7 +52,7 @@ export function serializeToDateTimeOffset(
     const precisionFormat = new Array(precision).fill('S').join('');
     return value.utc().format(`YYYY-MM-DDTHH:mm:ss.${precisionFormat}`) + 'Z';
   }
-  // If no precision, return without decimal places
+  // If precision is undefined, default to 0
   return value.utc().format('YYYY-MM-DDTHH:mm:ss') + 'Z';
 }
 

diff --git a/packages/odata-v4/src/request-builder/update-request-builder.spec.ts b/packages/odata-v4/src/request-builder/update-request-builder.spec.ts
@@ -19,7 +19,6 @@ function createTestEntity() {
     .keyPropertyGuid(keyPropGuid)
     .keyPropertyString(keyPropString)
     .keyDateProperty(keyPropDate)
-    .dateTimeOffSetProperty(moment())
     .int32Property(int32Prop)
     .build();
 }

diff --git a/test-packages/e2e-tests/test/request-builder.spec.ts b/test-packages/e2e-tests/test/request-builder.spec.ts
@@ -26,7 +26,8 @@ async function createEntity(key: number) {
     .stringProperty('someValue')
     .dateProperty(moment(0))
     .timeOfDayProperty({ hours: 1, minutes: 2, seconds: 3 })
-    .dataTimeOffsetDataTimeProperty(moment(0))
+    .dataTimeOffsetDataTimeProperty(moment(0)) // has an undefined precision
+    .dataTimeOffsetTimestampProperty(moment(0)) // has precision set to 7
     .build();
   return requestBuilder.create(dataForCreation).execute(destination);
 }

diff --git a/test-packages/test-services-odata-v2/test-service/TestEntityApi.js b/test-packages/test-services-odata-v2/test-service/TestEntityApi.js
diff --git a/test-packages/test-services-odata-v2/test-service/TestEntityApi.js.map b/test-packages/test-services-odata-v2/test-service/TestEntityApi.js.map
diff --git a/test-packages/test-services-odata-v2/test-service/TestEntityApi.ts b/test-packages/test-services-odata-v2/test-service/TestEntityApi.ts
@@ -373,7 +373,8 @@ export class TestEntityApi<
         DECIMAL_PROPERTY: fieldBuilder.buildEdmTypeField(
           'DecimalProperty',
           'Edm.Decimal',
-          true
+          true,
+          5
         ),
         /**
          * Static representation of the {@link singleProperty} property for query construction.
@@ -409,7 +410,8 @@ export class TestEntityApi<
         TIME_PROPERTY: fieldBuilder.buildEdmTypeField(
           'TimeProperty',
           'Edm.Time',
-          true
+          true,
+          0
         ),
         /**
          * Static representation of the {@link dateTimeProperty} property for query construction.
@@ -418,7 +420,8 @@ export class TestEntityApi<
         DATE_TIME_PROPERTY: fieldBuilder.buildEdmTypeField(
           'DateTimeProperty',
           'Edm.DateTime',
-          true
+          true,
+          0
         ),
         /**
          * Static representation of the {@link dateTimeOffSetProperty} property for query construction.
@@ -427,7 +430,8 @@ export class TestEntityApi<
         DATE_TIME_OFF_SET_PROPERTY: fieldBuilder.buildEdmTypeField(
           'DateTimeOffSetProperty',
           'Edm.DateTimeOffset',
-          true
+          true,
+          0
         ),
         /**
          * Static representation of the {@link byteProperty} property for query construction.