feat: Respect precision for Odata V4 type Edm.DateTimeOffset
#5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KavithaSiva
changed the title
Edm.DateTimeOffsetEdm.DateTimeOffset
KavithaSiva
commented
Jan 16, 2025
Comment on lines
+2
to
+4
| '@sap-cloud-sdk/generator': minor | ||
| '@sap-cloud-sdk/odata-v4': minor | ||
| '@sap-cloud-sdk/odata-common': minor |
There was a problem hiding this comment.
[q] Should I write major here? What is the correct heading for the PR then? feat needs a changeset with minor.
This was referenced Jan 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SAP/cloud-sdk-backlog#1261.
v3-mainnow, which is not for v4 development.mainbranch (for v4), I've updated (V4-Upgrade-Guide.md)[./V4-Upgrade-Guide.md] in case my change has any implications for users updating to SDK v4