Remove incorrect dependencies from setup.cfg
#4443
Conversation
|
I'm not sure if a ChangeLog entry is appropriate since it tackles build details and should not have any user-facing changes. |
Yes. CHANGES.txt should have both user and non-user facing items. Same with RELEASE.txt. |
Remove the `install_requires` on `setuptools`. This key is used to specify packages that are needed at runtime. SCons nowhere in its code does import `setuptools` or `pkg_resources`. Remove the `setup_requires` on `build`. `build` is a frontend package and a detail of how the build is invoked, while `setup_requires` are used to specify backend dependencies (i.e. packages that are installed after `build` is invoked). Remove the `setup_requires` on `setuptools`. It is a key specific to setuptools, so for it to be interpreted `setuptools` need to be installed already. The actual backend dependency on `setuptools` is specified in `pyproject.toml`, so the dependency is entirely redundant.
mgorny
force-pushed
the
setup-cfg-deps
branch
from
d0140f8 to
e27b28c
Compare
|
I've added the changelog entry and release note. |
| install_requires = setuptools | ||
| setup_requires = | ||
| setuptools | ||
| build |
There was a problem hiding this comment.
Should this ('build') be added to pyproject.toml's
[build-system]
build-backend = "setuptools.build_meta"
requires = ["setuptools"]
There was a problem hiding this comment.
No, it is a frontend. It is not used on the backend because it's build installing stuff from requires.
|
Thanks for the PR Merging! |
|
Thanks! |
mwichmann
added
the
Release
|
@mwichmann Is it possible to get this change in a 4.6.1 sooner than 4.7? The setuptools dependency is a bit of a bother for Python 3.12 users. Thanks! |
|
I believe we're very close to a 4.7. @bdbaddog - thoughts? |
Remove the
install_requiresonsetuptools. This key is used to specify packages that are needed at runtime. SCons nowhere in its code does importsetuptoolsorpkg_resources.Remove the
setup_requiresonbuild.buildis a frontend package and a detail of how the build is invoked, whilesetup_requiresare used to specify backend dependencies (i.e. packages that are installed afterbuildis invoked).Remove the
setup_requiresonsetuptools. It is a key specific to setuptools, so for it to be interpretedsetuptoolsneed to be installed already. The actual backend dependency onsetuptoolsis specified inpyproject.toml, so the dependency is entirely redundant.Contributor Checklist:
CHANGES.txt(and read theREADME.rst)