Modernize stat usage #4627
Merged
Modernize stat usage #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, problems went undetected because my dev machine wasn't reporting results properly due to previous virtualenv damage I thought I'd finished repairing. Will sort out shortly. |
|
Ah... affects sconsign - |
mwichmann
force-pushed
the
maint/st_mode
branch
2 times, most recently
from
68e41a9 to
162cdcc
Compare
|
@mwichmann I merged from main with the intent to clear up the failing ninja tests and get an all pass on the CI tests. |
Since Python 2.2, the object returned by an os.stat() call presents attributes matching the 10-tuple of stat values. Use these instead of indexing into the tuple. As usual for non-removed tests, minor tweaks made if needed - copyright header and DefautlEnvironment() call for performance. Signed-off-by: Mats Wichmann <[email protected]>
If a stat_result object's st_*time attributes are used, a float is returned instead of an int. Adjust sconsign test regexes to optionally accept a .digits tail of the number. Confirmed this works for both indexed attributes (which return an int) and named attributes (float). Signed-off-by: Mats Wichmann <[email protected]>
A previous change proposed flipping all of the Python stat references from the older tuple index style (st[stat.ST_XXX]) to the more modern stat structure references (st.st_xxx). This change rolls back the one place in the actual SCons code (in Node/FS) that used the stat mtime attribute. There's a small chance that switching scons versions back and forth could cause some time comparison issues, since st_mtime is a float, but for backwards compatibility reasons with ancient Python 2 versions Python retained the integer behavior of the index form. While problems from this seem a low probability, avoid the issue for now. Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
force-pushed
the
maint/st_mode
branch
from
6c976eb to
3f6be17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 2.2, the object returned by an
os.stat()call presents attributes matching the 10-tuple ofstatvalues. Use these instead of indexing into the tuple (which is now considered "backwards-compatibility" mode).As usual for non-removed tests, minor tweaks made if needed - copyright header and
DefautlEnvironment()call for performance.This change has no visibility into docs.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).