Remove Python 3.6 support #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Repiteo
force-pushed
the
remove-python-3.6
branch
from
162edf2 to
2908fd2
Compare
mwichmann
added
maintenance
bdbaddog
reviewed
Nov 14, 2024
| @@ -1356,12 +1356,6 @@ def order(dependencies): | |||
| # various print_* settings, tree_printer list, etc. | |||
| BuildTask.options = options | |||
|
|
|||
| is_pypy = platform.python_implementation() == 'PyPy' | |||
There was a problem hiding this comment.
why are you removing is_pypy ?
There was a problem hiding this comment.
It and is_37_or_later were only used in the commented-out python_has_threads variable. I could just leave it be, but I was already removing the redundant is_37_or_later which would otherwise just be an unreferenced variable always returning True, so removing that whole vestigial block felt more appropriate
bdbaddog
reviewed
Nov 14, 2024
|
Just a couple queries/requested changes and we should be able to merge. |
Repiteo
force-pushed
the
remove-python-3.6
branch
from
2908fd2 to
c28e720
Compare
|
My bad, didn't see your review until just now |
Repiteo
force-pushed
the
remove-python-3.6
branch
from
c28e720 to
37530ad
Compare
|
Also, would we want to mark 3.7 as deprecated as well? Or is that better suited for another PR and/or not necessary atm? |
|
let's do 3.7 separately |
mwichmann
reviewed
Nov 16, 2024
|
Good work. THanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all references to the deprecated 3.6 version, updating documentation and tests to account for the new baseline. This is a deliberately standalone PR, as any functional changes that'd come from it are better suited for evaluation in an isolated environment.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).