Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Help()'s local_only arg to match documents. #4670

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

bdbaddog
Copy link
Contributor

Previously the manpage specified that the argument to Help() which would cause it to only use help from AddOption()'s in -h's output should be local_only, however the code and tests were using keep_local. Now the code matches the documentation.

This is an alternate fix to hedgers #4606

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

…ment. Now code matches the documentation. Additionally fixturized the Help test
…ment. Now code matches the documentation. Additionally fixturized the Help test
@bdbaddog bdbaddog added the args_and_options options processing, arguments, get/setoption and their relationshiop label Dec 22, 2024
@bdbaddog bdbaddog requested a review from mwichmann December 22, 2024 01:27
@bdbaddog bdbaddog merged commit ef05417 into SCons:master Dec 29, 2024
7 of 8 checks passed
@bdbaddog bdbaddog deleted the fix_help_local_only branch December 29, 2024 04:55
@mwichmann mwichmann added this to the 4.9 milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
args_and_options options processing, arguments, get/setoption and their relationshiop
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants